[libcxx-commits] [PATCH] D129054: [libc++] Consolidate the different [[nodiscard]] configuration options into a single one

Nico Weber via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 31 12:30:37 PDT 2022


thakis added a comment.

We (used to) use _LIBCPP_ENABLE_NODISCARD. I only happened to see this change here by coincidence.

It would be nice if there was a

  #ifdef _LIBCPP_ENABLE_NODISCARD
  #error _LIBCPP_ENABLE_NODISCARD no longer has an effect, define _LIBCPP_ENABLE_NODISCARD_EXT
  #endif

in some central header to inform people in a similar situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129054/new/

https://reviews.llvm.org/D129054



More information about the libcxx-commits mailing list