[libcxx-commits] [PATCH] D131855: [libc++] Refactors charconv data tables.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I am extremely tempted to simply drop support for `to_chars` and `from_chars` before C++17 so that none of this is necessary anymore. Would you be willing to create a patch for that? I could run it through some tests to gauge the impact and we can see whether that's viable for LLVM 16.



================
Comment at: libcxx/include/__charconv/tables.h:45
 };
+#  endif
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131855/new/

https://reviews.llvm.org/D131855