[libcxx-commits] [PATCH] D131855: [libc++] Refactors charconv data tables.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__charconv/to_chars_base_10.h:39
 _LIBCPP_HIDE_FROM_ABI inline char* __append2(char* __first, uint32_t __value) noexcept {
-  return std::copy_n(&__table<>::__digits_base_10[__value * 2], 2, __first);
+  return std::copy_n(&_LIBCPP_ITOA_TABLE_DIGITS_BASE_10[__value * 2], 2, __first);
 }
----------------
However this runs into https://github.com/llvm/llvm-project/issues/52954
I have added a comment in the source, which I will update on the next revision or when landing.

The same for similar occurrences in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131855/new/

https://reviews.llvm.org/D131855