[libcxx-commits] [libcxx] 8e29e37 - [libcxx] [test] Remove an unnecessary condition in a feature check

Martin Storsjö via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 30 00:08:52 PDT 2022


Author: Martin Storsjö
Date: 2022-08-30T10:06:52+03:00
New Revision: 8e29e379b03541ae8dcfb9e797bfc3305f2a8756

URL: https://github.com/llvm/llvm-project/commit/8e29e379b03541ae8dcfb9e797bfc3305f2a8756
DIFF: https://github.com/llvm/llvm-project/commit/8e29e379b03541ae8dcfb9e797bfc3305f2a8756.diff

LOG: [libcxx] [test] Remove an unnecessary condition in a feature check

We don't need to check for `_LIBCPP_HAS_NO_LOCALIZATION` here;
this was copied over by mistake from the test above (which does
use locale.h).

Differential Revision: https://reviews.llvm.org/D132834

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/features.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py
index e7dc18310b990..46bbd2427f0a7 100644
--- a/libcxx/utils/libcxx/test/features.py
+++ b/libcxx/utils/libcxx/test/features.py
@@ -99,7 +99,7 @@ def _hasSuitableClangQuery(cfg):
   # Check for a Windows UCRT bug (fixed in UCRT/Windows 10.0.19041.0).
   # https://developercommunity.visualstudio.com/t/printf-formatting-with-g-outputs-too/1660837
   Feature(name='win32-broken-printf-g-precision',
-          when=lambda cfg: not '_LIBCPP_HAS_NO_LOCALIZATION' in compilerMacros(cfg) and '_WIN32' in compilerMacros(cfg) and not programSucceeds(cfg, """
+          when=lambda cfg: '_WIN32' in compilerMacros(cfg) and not programSucceeds(cfg, """
             #include <stdio.h>
             #include <string.h>
             int main(int, char**) {


        


More information about the libcxx-commits mailing list