[libcxx-commits] [PATCH] D128998: [libunwind] Handle G in personality string

[Florian Mayer via Phabricator via libcxx-commits]

fmayer added a comment.

In D128998#3723720 <https://reviews.llvm.org/D128998#3723720>, @fmayer wrote:

> In D128998#3721563 <https://reviews.llvm.org/D128998#3721563>, @MaskRay wrote:
>
>> About `__unw_clean_step`:
>>
>> libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
>> Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.
>
> AFAICT my change does not in fact expose a new API, because it does not use `_LIBUNWIND_WEAK_ALIAS`, so `__unw_clean_step` will remain hidden visiblity.

Ping. Should I move the `extern int __unw_clean_step(unw_cursor_t *);` declaration out of libunwind_ext.h if I don't want it to be an API?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998