[libcxx-commits] [PATCH] D131963: [libc++] Add custom clang-tidy checks

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D131963#3754318 <https://reviews.llvm.org/D131963#3754318>, @avogelsgesang wrote:

> is there a reason why we add our own clang-tidy plugin instead of upstreaming this to `clang-tidy` itself? I could imagine that other library developers could also benefit from this clang-tidy check, if we make the list of allowed customization points a configuration option

We can definitely do this for some checks, but I don't think it makes sense for all checks. I'd like to extend our `_LIBCPP_HIDE_FROM_ABI` check for example, but that check probably doesn't make sense for any other project. Upstreaming a check would also mean that we'd have to wait up to six months before being able to enforce it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131963/new/

https://reviews.llvm.org/D131963