[libcxx-commits] [PATCH] D129094: [libc++] Simplify type_traits a bit more

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h:26
   constexpr explicit CopyConstructible(int x) : value(x) { }
-  CopyConstructible(CopyConstructible const&) noexcept(false) = default;
+  constexpr CopyConstructible(CopyConstructible const&) noexcept(false) {}
   CopyConstructible& operator=(CopyConstructible const&) = delete;
----------------
STL_MSFT wrote:
> philnik wrote:
> > huixie90 wrote:
> > > why is this change required?
> > This isn't actually required. I thought it was implementation divergence, but it's a GCC bug. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106611. @CaseyCarter @STL_MSFT you might also want to look into that.
> I'm missing context here - apologies for not being up to speed. MSVC's STL supports MSVC and Clang as first-class citizens (and we use libcxx's test suite with our STL), but we don't attempt to support GCC. Are you requesting any changes to MSVC's compiler or libraries here that we could help with?
The MSVC compiler has very similar bugs regarding noexcept specifications on defaulted special member functions. https://godbolt.org/z/1z4fb11hr is the full reproducer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129094/new/

https://reviews.llvm.org/D129094