[libcxx-commits] [PATCH] D129094: [libc++] Simplify type_traits a bit more

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 26 14:22:29 PDT 2022


philnik added subscribers: CaseyCarter, STL_MSFT.
philnik added inline comments.


================
Comment at: libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h:26
   constexpr explicit CopyConstructible(int x) : value(x) { }
-  CopyConstructible(CopyConstructible const&) noexcept(false) = default;
+  constexpr CopyConstructible(CopyConstructible const&) noexcept(false) {}
   CopyConstructible& operator=(CopyConstructible const&) = delete;
----------------
huixie90 wrote:
> why is this change required?
This isn't actually required. I thought it was implementation divergence, but it's a GCC bug. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106611. @CaseyCarter @STL_MSFT you might also want to look into that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129094/new/

https://reviews.llvm.org/D129094



More information about the libcxx-commits mailing list