[libcxx-commits] [PATCH] D131732: [libcxx][NFC] utilises compiler builtins for unary transform type-traits

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D131732#3752063 <https://reviews.llvm.org/D131732#3752063>, @philnik wrote:

> @cjdb I meant that the other `decay` implementation should be fixed to be the same as the builtin. IOW the one that GCC uses, since it doesn't have the builtin. Sorry for the confusion.

Thanks for clarifying. After double checking the Clang test, I see that `__decay` strips all qualifiers: not just `__restrict`. For example, `int* _Nonnull` will become `int*`. There are a lots of these <https://clang.llvm.org/docs/AttributeReference.html>, and I'm not sure how we'd want to handle this without ironically impacting build times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131732/new/

https://reviews.llvm.org/D131732