[libcxx-commits] [PATCH] D132667: [libc++] Inlines format_error for clang-cl DLL.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Not much opinion on the change itself, but one nitpick about a comment.



================
Comment at: libcxx/include/__format/format_error.h:35
+  // TODO FMT Remove when format is no longer experimental.
+  // Avoids linker errors when building the Clang Windows DLL which doesn't support the experimental library
+#  ifndef _LIBCPP_INLINE_FORMAT_ERROR_DTOR
----------------
Nitpick, "Clang-cl", or "MSVC mode" or something like that, but not plain "Clang".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132667/new/

https://reviews.llvm.org/D132667