[libcxx-commits] [PATCH] D132284: [libc++] Reduces the number of transitive includes.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

Assuming we still plan to remove transitive includes at some point I'm OK with this approach, as it gives us a lot more flexibility when to remove them.



================
Comment at: libcxx/docs/DesignDocs/HeaderRemovalPolicy.rst:11
+headers. For example, instead of including ``<algorithm>`` entirely it is
+possible to only include only the headers for the algorithms used. When the
+Standard indirectly adds additional header includes, using the smaller headers
----------------



================
Comment at: libcxx/docs/DesignDocs/HeaderRemovalPolicy.rst:32-33
+that users will have to fix their missing includes in order to upgrade to a
+newer version of the Standard. Libc++ also reserves the right to remove
+transitive includes at any other time, however new language versions will be
+used as a convenient way to perform bulk removals of
----------------
Would the plan still be to remove transitive includes at some point? If not the includes will probably end up in a huge mess.


================
Comment at: libcxx/docs/DesignDocs/HeaderRemovalPolicy.rst:34
+transitive includes at any other time, however new language versions will be
+used as a convenient way to perform bulk removals of
+
----------------
I think you are missing something here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132284/new/

https://reviews.llvm.org/D132284