[libcxx-commits] [PATCH] D132593: [libc++][NFC] Use `#error message` instead of `#error "message"`

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 25 06:10:32 PDT 2022


ldionne added a comment.

In D132593#3747378 <https://reviews.llvm.org/D132593#3747378>, @philnik wrote:

> Are you sure we want to do this? This breaks if you have any `'`s in your message. Couldn't clang just remove the `"` when the only thing in the error message is a string?

That is a *much* better idea indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132593/new/

https://reviews.llvm.org/D132593



More information about the libcxx-commits mailing list