[libcxx-commits] [PATCH] D132626: [libc++][test] Use TEST_HAS_NO_CHAR8_T to simplify #ifdefs. NFCI.

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 24 17:59:28 PDT 2022


jloser created this revision.
jloser added reviewers: philnik, Mordante, var-const, ldionne.
Herald added a project: All.
jloser requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Many tests in `libcxx/test/std/strings` use `#if defined(__cpp_lib_char8_t) &&
__cpp_lib_char8_t >= 201811L` which can be replaced with the more terse `#ifndef
TEST_HAS_NO_CHAR8_T`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132626

Files:
  libcxx/test/std/strings/basic.string.hash/enabled_hashes.pass.cpp
  libcxx/test/std/strings/basic.string.hash/strings.pass.cpp
  libcxx/test/std/strings/basic.string.literals/literal.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/assign2.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/assign3.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/compare.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/copy.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/eof.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/eq.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/eq_int_type.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/find.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/length.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/lt.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/move.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/not_eof.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/to_char_type.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/to_int_type.pass.cpp
  libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/types.pass.cpp
  libcxx/test/std/strings/string.classes/typedefs.compile.pass.cpp
  libcxx/test/std/strings/string.view/string.view.capacity/capacity.pass.cpp
  libcxx/test/std/strings/string.view/string.view.cons/assign.pass.cpp
  libcxx/test/std/strings/string.view/string.view.cons/default.pass.cpp
  libcxx/test/std/strings/string.view/string.view.cons/from_string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.hash/enabled_hashes.pass.cpp
  libcxx/test/std/strings/string.view/string.view.hash/string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.iterators/begin.pass.cpp
  libcxx/test/std/strings/string.view/string.view.iterators/end.pass.cpp
  libcxx/test/std/strings/string.view/string.view.iterators/rbegin.pass.cpp
  libcxx/test/std/strings/string.view/string.view.iterators/rend.pass.cpp
  libcxx/test/std/strings/string.view/string_view.literals/literal.pass.cpp
  libcxx/test/std/strings/string.view/types.pass.cpp
  libcxx/test/std/utilities/meta/meta.unary/meta.unary.cat/is_integral.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132626.455443.patch
Type: text/x-patch
Size: 26179 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220825/403703bc/attachment-0001.bin>


More information about the libcxx-commits mailing list