[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

Vitaly Buka via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 24 13:16:26 PDT 2022


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_poisoning.cpp:357-362
   if (!(beg <= old_mid && beg <= new_mid && old_mid <= end && new_mid <= end &&
         IsAligned(beg, granularity))) {
     GET_STACK_TRACE_FATAL_HERE;
     ReportBadParamsToAnnotateContiguousContainer(beg, end, old_mid, new_mid,
                                                  &stack);
   }
----------------
to my taste this is CHECK() case, but no need to change in this patch
can simplify this in later (on in before) patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090



More information about the libcxx-commits mailing list