[libcxx-commits] [PATCH] D132593: [libc++][NFC] Use `#error message` instead of `#error "message"`

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 24 12:38:14 PDT 2022


ldionne created this revision.
Herald added subscribers: arphaman, arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

Even though I've always used the latter, the former is the more correct
way to use the preprocessing directive, since the compiler expects a
sequence of 'pp-tokens'.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132593

Files:
  libcxx/include/__assert
  libcxx/include/__availability
  libcxx/include/__config
  libcxx/include/__debug
  libcxx/include/__mbstate_t.h
  libcxx/include/__support/win32/limits_msvc_win32.h
  libcxx/include/barrier
  libcxx/include/filesystem
  libcxx/include/future
  libcxx/include/ios
  libcxx/include/latch
  libcxx/include/locale.h
  libcxx/include/semaphore
  libcxx/include/shared_mutex
  libcxx/include/thread
  libcxx/include/wchar.h
  libcxx/include/wctype.h
  libcxx/src/chrono.cpp
  libcxx/src/filesystem/operations.cpp
  libcxx/src/random.cpp
  libcxx/test/libcxx/debug/debug.assertions-enabled.compile.pass.cpp
  libcxx/test/libcxx/experimental/algorithms/header.algorithm.synop/includes.pass.cpp
  libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp
  libcxx/test/libcxx/inclusions/algorithm.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/array.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/bitset.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/chrono.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/cinttypes.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/complex.h.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/coroutine.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/deque.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/filesystem.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/forward_list.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/ios.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/iostream.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/iterator.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/list.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/map.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/memory.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/optional.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/queue.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/random.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/ranges.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/regex.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/set.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/stack.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/string.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/string_view.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/system_error.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/tgmath.h.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/thread.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/tuple.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/typeindex.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/unordered_map.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/unordered_set.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/utility.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/valarray.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/variant.inclusions.compile.pass.cpp
  libcxx/test/libcxx/inclusions/vector.inclusions.compile.pass.cpp
  libcxx/test/libcxx/language.support/support.limits/version.pass.cpp
  libcxx/test/libcxx/language.support/support.rtti/type.info/type_info.comparison.apple.compile.pass.cpp
  libcxx/test/libcxx/memory/aligned_allocation_macro.compile.pass.cpp
  libcxx/test/libcxx/no_assert_include.compile.pass.cpp
  libcxx/test/libcxx/selftest/pass.mm/no-arc.pass.mm
  libcxx/test/libcxx/strings/basic.string/alignof.compile.pass.cpp
  libcxx/test/libcxx/strings/basic.string/sizeof.compile.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.capacity/max_size.pass.cpp
  libcxx/test/std/experimental/utilities/utility/utility.synop/includes.pass.cpp
  libcxx/test/std/language.support/support.dynamic/destroying_delete_t.pass.cpp
  libcxx/test/std/language.support/support.dynamic/destroying_delete_t_declaration.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/algorithm.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/any.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/array.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/atomic.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/barrier.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/bit.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/bitset.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/charconv.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/chrono.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/cmath.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/compare.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/complex.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/concepts.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/coroutine.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/cstddef.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/cstdlib.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/deque.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/exception.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/execution.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/filesystem.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/format.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/forward_list.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/functional.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/iomanip.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/istream.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/iterator.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/latch.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/limits.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/list.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/locale.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/map.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/memory.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/mutex.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/new.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/numbers.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/numeric.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/optional.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/ostream.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/queue.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/ranges.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/regex.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/scoped_allocator.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/semaphore.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/set.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/shared_mutex.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/span.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/stack.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/stdatomic.h.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/string.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/string_view.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/thread.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/tuple.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/type_traits.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/typeinfo.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/unordered_map.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/unordered_set.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/utility.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/variant.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/vector.version.compile.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/version.version.compile.pass.cpp
  libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp
  libcxx/test/support/check_assertion.h
  libcxx/test/support/test.support/test_macros_header.exceptions.pass.cpp
  libcxx/test/support/test.support/test_macros_header.no_exceptions.verify.cpp
  libcxx/test/support/test.support/test_macros_header.no_rtti.verify.cpp
  libcxx/test/support/test.support/test_macros_header.rtti.pass.cpp
  libcxx/test/support/test_format_context.h
  libcxx/utils/generate_feature_test_macro_components.py
  libcxx/utils/generate_header_inclusion_tests.py
  libcxxabi/src/cxa_guard_impl.h



More information about the libcxx-commits mailing list