[libcxx-commits] [PATCH] D131174: [libc++][CI] Increases the Clang version used.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

There's a few comments, but this LGTM. Thanks a lot, this is a realllllly nice improvement. This will decouple updating the compilers for CI from updating the Docker image on runners, which has been a source of pain in the past.

Just so that we're on the same page, this will also expose us to potential breaks in the nightly Clang build when we update the Docker image. However, I think that's acceptable since we can do basic testing before updating the Docker image.



================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:174
     command: "libcxx/utils/ci/run-buildbot generic-cxx20"
     artifact_paths:
       - "**/test-results.xml"
----------------
I think these jobs were forgotten.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:215
   # Tests with the supported compilers.
   - label: "GCC 12 / C++11"
     command: "libcxx/utils/ci/run-buildbot generic-gcc-cxx11"
----------------
Is this supported? That would be nice.


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:356
   - label: "Bootstrapping build"
     command: "libcxx/utils/ci/run-buildbot bootstrapping-build"
     artifact_paths:
----------------
I think this one should be using `clang-head` too. It just means that we will build Clang from scratch using `clang-head`, and then we'll build libc++ using the just-built `clang-fromscratch`.

It's mostly for consistency with other CI jobs, I guess, because in practice we should be able to build Clang from scratch using almost any system compiler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131174/new/

https://reviews.llvm.org/D131174