[libcxx-commits] [PATCH] D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2

[John Ericson via Phabricator via libcxx-commits]

Ericson2314 marked an inline comment as done.
Ericson2314 added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:75
 
 option(LIBCXXABI_INCLUDE_TESTS "Generate build targets for the libc++abi unit tests." ${LLVM_INCLUDE_TESTS})
 set(LIBCXXABI_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}" CACHE STRING
----------------
phosek wrote:
> This option is defined after the `include(HandleLibCXX)` statement but you use its value inside `HandleLibCXX.cmake`, isn't that always going to evaluate as falsy?
Oops good point. I was setting that manually so didn't catch.


================
Comment at: libcxxabi/cmake/Modules/HandleLibCXX.cmake:4-6
+option(LIBCXXABI_USE_PREBUILT_LIBCXX_HEADERS
+    "Use prebuilt libc++ headers because we are not also building libcc++."
+    OFF)
----------------
My `TARGET cxx-headers` trick didn't work because that target isn't defined until afterwords, since `libcxx` mostly depends on`libcxxabi`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132526/new/

https://reviews.llvm.org/D132526