[libcxx-commits] [PATCH] D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 23 23:35:23 PDT 2022
phosek added inline comments.
================
Comment at: libcxxabi/CMakeLists.txt:75
option(LIBCXXABI_INCLUDE_TESTS "Generate build targets for the libc++abi unit tests." ${LLVM_INCLUDE_TESTS})
set(LIBCXXABI_LIBDIR_SUFFIX "${LLVM_LIBDIR_SUFFIX}" CACHE STRING
----------------
This option is defined after the `include(HandleLibCXX)` statement but you use its value inside `HandleLibCXX.cmake`, isn't that always going to evaluate as falsy?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132526/new/
https://reviews.llvm.org/D132526
More information about the libcxx-commits
mailing list