[libcxx-commits] [PATCH] D132310: [libc++][regex] Uses operator<=> in sub_match.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 23 08:51:09 PDT 2022


Mordante marked 2 inline comments as done.
Mordante added a comment.

In D132310#3738243 <https://reviews.llvm.org/D132310#3738243>, @avogelsgesang wrote:

>> I'll put this on hold until D131395 <https://reviews.llvm.org/D131395> lands, then I can address your final review comment.
>
> Well, that might still take a while... That review turned out to be a suprisingly deep rat hole and time sink.
>
> If you want to move ahead with this patch independently, please feel free to just copy the `{Weak,Partial}Order` helpers. I have no problem rebasing on your change, in case this review here lands first.

I'm not really in a hurry with this patch, it's not really blocking other work and we're not near to branching a new version of LLVM. So I don't mind waiting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132310/new/

https://reviews.llvm.org/D132310



More information about the libcxx-commits mailing list