[libcxx-commits] [PATCH] D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build

Tue Aug 23 07:34:46 PDT 2022

Ericson2314 marked 2 inline comments as done.
Ericson2314 added inline comments.

================
Comment at: libcxxabi/test/CMakeLists.txt:64

-if(libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
+if ((NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES) AND (NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS))
   list(APPEND LIBCXXABI_TEST_DEPS cxx)
----------------
kadircet wrote:
> isn't the first `NOT` here, before `libcxx` is wrong? (same for below)
> 
> i think we want `libcxx` to be present in RUNTIMES but not in PROJECTS.
Yeah it is wrong. Stupid copy past mistake. More reason the revert proposed rather than me failing to ninja fixes is the right approach.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132411/new/

https://reviews.llvm.org/D132411