[libcxx-commits] [PATCH] D132312: [libc++][spaceship] Implement `operator<=>` for `list`

[Hui via Phabricator via libcxx-commits]

huixie90 added a comment.

I think I also agree on the comments with regard to the tests



================
Comment at: libcxx/include/list:2341
+template<class _Tp, class _Allocator>
+__synth_three_way_result<_Tp>
+operator<=>(const list<_Tp, _Allocator>& __x, const list<_Tp, _Allocator>& __y)
----------------
`_LIBCPP_HIDE_FROM_ABI`


================
Comment at: libcxx/include/list:2341
+template<class _Tp, class _Allocator>
+__synth_three_way_result<_Tp>
+operator<=>(const list<_Tp, _Allocator>& __x, const list<_Tp, _Allocator>& __y)
----------------
huixie90 wrote:
> `_LIBCPP_HIDE_FROM_ABI`
perhaps I missed something but have you included the header that defines `__synth_three_way_result`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132312/new/

https://reviews.llvm.org/D132312