[libcxx-commits] [PATCH] D132310: [libc++][regex] Uses operator<=> in sub_match.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante marked 9 inline comments as done.
Mordante added a comment.

Thanks for the review! I'll put this on hold until D131395 <https://reviews.llvm.org/D131395> lands, then I can address your final review comment.

In D132310#3737499 <https://reviews.llvm.org/D132310#3737499>, @avogelsgesang wrote:

> can you please add a new row to the status doc for the removal of the `operator!=` on `match_results`? So we don't forget about it...

I already have a patch for the `operator!=` removal, changing that in this patch will lead to merge conflicts so I will not add it here. I will upload that patch after this one lands; just to avoid merge conflicts.



================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.op/compare.pass.cpp:247
 {
+#if TEST_STD_VER >17
+    AssertOrderReturn<std::strong_ordering, std::basic_string<CharT>>();
----------------
avogelsgesang wrote:
> missing whitespace. Here and other places in this header
I see I rely too much on clang-format ;-)


================
Comment at: libcxx/test/std/re/re.submatch/re.submatch.op/compare.pass.cpp:248-251
+    AssertOrderReturn<std::strong_ordering, std::basic_string<CharT>>();
+#else
+    AssertCompareReturnBool<std::basic_string<CharT>>();
+#endif
----------------
avogelsgesang wrote:
> shouldn't this rather check `sub_match`?
> Move below the `typedef ... sub_match` and test for `sub_match`?
Guess I copy pasted it, but it indeed should be `sub_match`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132310/new/

https://reviews.llvm.org/D132310