[libcxx-commits] [PATCH] D132310: [libc++][regex] Uses operator<=> in sub_match.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Aug 20 12:11:14 PDT 2022


Mordante created this revision.
Mordante added reviewers: avogelsgesang, mumbleskates.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

The removal of operator!= in this header will be done in a separate
commit.

Note in the synopsis of P1614R2 there is a constexpr

  template<class BiIter>
    constexpr auto operator<=>(const sub_match<BiIter>& lhs, const sub_match<BiIter>& rhs);

In the implementation of P1614R2 there isn't a constexpr

  template<class BiIter>
    auto operator<=>(const sub_match<BiIter>& lhs, const sub_match<BiIter>& rhs);

There doesn't seem to be an LWG-issue, but it was fixed in the Standard
by removing the constexpr in b050fd474f11441942c88ef69b8622c8036656ac.

Implements part of:

- P1614R2 The Mothership has Landed


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132310

Files:
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/include/regex
  libcxx/test/std/re/re.submatch/re.submatch.op/compare.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132310.454243.patch
Type: text/x-patch
Size: 19764 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220820/d0234de3/attachment-0001.bin>


More information about the libcxx-commits mailing list