[libcxx-commits] [PATCH] D103198: [libc++] Add a CI configuration where we test the PSTL integration

[Thomas Rodgers via Phabricator via libcxx-commits]

rodgert added inline comments.


================
Comment at: libcxx/include/algorithm:1673
+// TODO: Remove this include once we fix transitive includes of <algorithm>
+#  include <__functional/not_fn.h>
+#  include <__pstl_algorithm>
----------------
philnik wrote:
> ldionne wrote:
> > I think the PSTL should be more tightly integrated with libc++, and we should probably be including libc++'s internal headers directly from it to break these kinds of circular dependencies.
> > 
> > This is going to be non-trivial though because there was an intent to share the PSTL between libc++ and libstdc++ -- I don't know whether that is still desired, and we may need to revisit this if we want to ease the integration between libc++ and PSTL.
> > 
> > @rodgert What is the current state of PSTL within libstdc++? How do you integrate it nowadays? Back in the days, I think you had a script that basically copied the sources to libstdc++ -- if that's still the case, do you have plans to keep it up to date, and can you link to that script so we can take a look at how the integration works?
> If we want to do that it should probably be in a separate PR.
> @rodgert What is the current state of PSTL within libstdc++? 

I pulled a new version in 2020 and have not rebased since. I had been waiting on the tag dispatch rewrite before considering the process again. I also not seen any progress on that since January, so maybe I will rethink matters if that continues.

I think any changes to include libc++'s internal headers would be detrimental to the continued to sharing of this codebase. I deliberately have not done that so far with libstdc++ (or I maintain those changes downstream only) because that would almost certainly introduce massive and likely unresolvable breakage for libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103198/new/

https://reviews.llvm.org/D103198