[libcxx-commits] [libcxx] e78223e - [libcxx] [test] Remove --env PATH from the static clangcl config

[Martin Storsjö via libcxx-commits]

Author: Martin Storsjö
Date: 2022-08-19T11:40:58+03:00
New Revision: e78223e79efc886ef6f0ea5413deab3737d6d63b

URL: https://github.com/llvm/llvm-project/commit/e78223e79efc886ef6f0ea5413deab3737d6d63b
DIFF: https://github.com/llvm/llvm-project/commit/e78223e79efc886ef6f0ea5413deab3737d6d63b.diff

LOG: [libcxx] [test] Remove --env PATH from the static clangcl config

The PATH is set in order to be able to find the tested DLL at runtime.
When linking statically, it's not necessary to set the PATH.

Setting PATH in the executor has the downside that it clears the
existing path (it's not prepended/appended to it), which means
that the executed tools can't find other tools - which sets the
executor-has-no-bash flag.

By removing the unnecessary setting of PATH, we have a properly
working bash even when wrapped by the executor, which gets rid
of the executor-has-no-bash flag in this test configuration, which
makes 9 more testcases be executed.

Differential Revision: https://reviews.llvm.org/D131481

Added: 
    

Modified: 
    libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in

Removed: 
    


################################################################################
diff  --git a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
index 2f408a09bf9ec..460f7d6d50d4f 100644
--- a/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
+++ b/libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in
@@ -11,7 +11,7 @@ config.substitutions.append(('%{link_flags}',
     '-nostdlib -L %{lib} -llibc++ -lmsvcrt -lmsvcprt -loldnames'
 ))
 config.substitutions.append(('%{exec}',
-    '%{executor} --execdir %T --env PATH=%{lib} -- '
+    '%{executor} --execdir %T -- '
 ))
 
 import os, site