[libcxx-commits] [PATCH] D132151: [libc++] Make <ranges> non-experimental
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Aug 18 13:59:05 PDT 2022
ldionne marked an inline comment as done.
ldionne added a comment.
In D132151#3733214 <https://reviews.llvm.org/D132151#3733214>, @philnik wrote:
> LGTM assuming you grepped for `_LIBCPP_HAS_NO_INCOMPLTE_RANGES` and not just `!defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)` or something like that.
Yes, I did. Without the typo :-)
================
Comment at: libcxx/test/std/ranges/range.adaptors/range.join.view/iterator/iter.move.pass.cpp:31
{
- // iter_move calls inner's iter_move and calls
// iter_move on the correct inner iterator
----------------
philnik wrote:
> Can we get something in `generated output` that checks for trailing whitespaces?
D132175
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132151/new/
https://reviews.llvm.org/D132151
More information about the libcxx-commits
mailing list