[libcxx-commits] [PATCH] D129428: [libcxx] [test] Fix the transitive_includes test on Windows

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but the writing in binary mode looks really arcane, I'd like to understand why it's needed.



================
Comment at: libcxx/test/libcxx/transitive_includes.sanitize.py:38-41
+# Write the output to stdout in binary mode, with '\n' linebreaks on all
+# platforms.
+sys.stdout.buffer.write(bytes('\n'.join(sorted(set(headers))), 'ascii'))
+sys.stdout.buffer.write(b'\n')
----------------
Can you explain what's the problem with the original version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129428/new/

https://reviews.llvm.org/D129428