[libcxx-commits] [PATCH] D131898: [libc++] Implement P0591R4 (Utility functions to implement uses-allocator construction)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Please go through D58879 <https://reviews.llvm.org/D58879> and reuse anything useful (esp. from the tests). Including comments like https://reviews.llvm.org/D58879#1546317. Then we can close D58879 <https://reviews.llvm.org/D58879> since this supersedes it.



================
Comment at: libcxx/include/__memory/uses_allocator_construction.h:30
+
+template <
+    class _Type,
----------------
Maybe this should be three functions instead, it would be easier to read.


================
Comment at: libcxx/include/__memory/uses_allocator_construction.h:150
+__uses_allocator_construction_args(const _Alloc& __alloc, _Type&& __value) noexcept {
+  struct __pair_constructor {
+    using _PairMut = remove_cv_t<_Pair>;
----------------
FYI this seems to be the resolution of http://wg21.link/LWG3525. I assume now you know how to test it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131898/new/

https://reviews.llvm.org/D131898