[libcxx-commits] [PATCH] D131484: [libcxx] [test] Split the TEST_HAS_SANITIZERS define into TEST_IS_SLOW

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 18 08:53:02 PDT 2022


mstorsjo added inline comments.


================
Comment at: libcxx/test/support/test_macros.h:190
 #define TEST_HAS_SANITIZERS
+#define TEST_IS_SLOW
 #endif
----------------
Mordante wrote:
> I think the name `TEST_IS_SLOW` is a bit generic, we have slow tests that don't use this. (*cough* format)
> How about `TEST_IS_EXECUTED_IN_A_SLOW_ENVIRONMENT` or something along these lines?
> 
Right, that makes sense. That macro sure is a mouthful, but it doesn’t need to be super convenient, so it’s probably fine. I can update the patch with that name later tonight.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131484/new/

https://reviews.llvm.org/D131484



More information about the libcxx-commits mailing list