[libcxx-commits] [PATCH] D131395: [libc++] Implement `lexicographical_compare_three_way`

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang updated this revision to Diff 453551.
avogelsgesang marked 5 inline comments as done.
avogelsgesang added a comment.

- use `__undef_macros`
- use `difference_type` instead of `size_t`
- use fast path only if both iterators have the same, integral `difference_type`
- also test with `int*` iterator type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131395/new/

https://reviews.llvm.org/D131395

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__algorithm/lexicographical_compare_three_way.h
  libcxx/include/algorithm
  libcxx/include/module.modulemap.in
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way.pass.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way_comp.pass.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.three.way/lexicographical_compare_three_way_comp.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131395.453551.patch
Type: text/x-patch
Size: 32162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220818/26c65722/attachment-0001.bin>