[libcxx-commits] [PATCH] D132028: [libc++] Replace _LIBCPP_INLINE_VISIBILITY and mark all functions _LIBCPP_HIDE_FROM_ABI in __split_buffer

[Hui via Phabricator via libcxx-commits]

huixie90 accepted this revision as: huixie90.
huixie90 added a comment.

LGTM



================
Comment at: libcxx/include/__split_buffer:41-42
 private:
     __split_buffer(const __split_buffer&);
     __split_buffer& operator=(const __split_buffer&);
 public:
----------------
Not an issue. At the first glance, I was wondering why these two were not marked as hidden from abi. then I realised that there are no implementations and these are just CXX03 way of making it non-copyable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132028/new/

https://reviews.llvm.org/D132028