[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with a nitpick. Also, please make sure to update the commit message, it mentions defining `_LIBCPP_NO_EXCEPTIONS` but that's not the case anymore.

Thanks everyone for your patience with this patch.



================
Comment at: libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in:3
+# using a DLL, with Clang-cl on Windows. This variant sets _HAS_EXCEPTIONS = 0
+# which removes exception class defintions  from the vcruntime.
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947