[libcxx-commits] [PATCH] D130859: [libc++] Implement `operator<=>` for `filesystem::path`

Adrian Vogelsgesang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 17 10:40:56 PDT 2022


avogelsgesang marked 2 inline comments as done.
avogelsgesang added inline comments.


================
Comment at: libcxx/include/filesystem:17
 
-    class path;
+    // `class path` from http://eel.is/c++draft/fs.class.path.general#6
+    class path {
----------------
Mordante wrote:
> We normally don't do this, but it's interesting to do this for those "hidden" synopsis.
> (I get the impression their number grows.) 
is your comment an ask to remove this and follow the established way of not including this?
Or does your " it's interesting to do this for those "hidden" synopsis" imply that it's interesting/useful enough so that we should keep this comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130859/new/

https://reviews.llvm.org/D130859



More information about the libcxx-commits mailing list