[libcxx-commits] [PATCH] D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion

[Dominic Chen via Phabricator via libcxx-commits]

ddcc added inline comments.


================
Comment at: libcxx/utils/libcxx/test/params.py:21
+  '-Wmacro-redefined',
+  '-Wsign-conversion',
+  '-Wzero-as-null-pointer-constant',
----------------
Don't think I can make this change yet. There's other related warnings:
```
atomic: warning: implicit conversion changes signedness: 'std::__memory_order_underlying_t' (aka 'unsigned int') to 'int' [-Wsign-conversion]
    __c11_atomic_signal_fence(static_cast<__memory_order_underlying_t>(__order));
```

I don't quite understand this bit, there's some comments about conditional behavior under `_LIBCPP_STD_VER > 17`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131929/new/

https://reviews.llvm.org/D131929