[libcxx-commits] [PATCH] D131441: [libc++] Diagnose when header search paths are set up incorrectly

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I actually built a significant codebase with this change, and the only few issues that popped up were places where include paths were indeed set up incorrectly. In most cases, I had also spent significant time in the past figuring out incorrect header path ordering in those parts of the code base, which would have been greatly helped by this diagnostic.

So yeah, I guess this gives me the confidence I needed that this change is good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131441/new/

https://reviews.llvm.org/D131441