[libcxx-commits] [PATCH] D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks for the patch!

> These warnings should be enabled in the test suite to avoid regressions.

@ddcc You can do that by adding them in `libcxx/utils/libcxx/test/params.py`.



================
Comment at: libcxx/include/atomic:2694
 
+#undef ATOMIC_FLAG_INIT
 #define ATOMIC_FLAG_INIT {false}
----------------
Is this because `ATOMIC_FLAG_INIT` was already defined by the C Library?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131929/new/

https://reviews.llvm.org/D131929