[libcxx-commits] [PATCH] D128577: [libc++][chrono] Implements formatter day.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 16 09:16:37 PDT 2022


ldionne added a comment.

Notes from live review:

1. Let's move transitive includes to the end of each file to break cycles
2. Let's guard transitive includes on standard versions

Also, please update this to its final form and we can take a look at the Windows DLL errors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128577/new/

https://reviews.llvm.org/D128577



More information about the libcxx-commits mailing list