[libcxx-commits] [PATCH] D131836: [libc++][CI] increases constexpr evaluation limit.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:42-51
+  # The default maximum number of operations in a constexpr function are too
+  # small for some tests. A "correct" value has been determined empirical.
+  Feature(name='clang-constexpr-steps',
+          when=lambda cfg: hasCompileFlag(cfg, '-fconstexpr-steps=1'),
+          actions=[AddCompileFlag('-fconstexpr-steps=128000000')]),
+
+  Feature(name='gcc-constexpr-steps',
----------------
Is there a reason we don't want this in `params.py`? I can't really see a case where we want to restrict tests based  on `clang-constexpr-steps` or `gcc-constexpr-steps`.


================
Comment at: libcxx/utils/libcxx/test/features.py:46
+          when=lambda cfg: hasCompileFlag(cfg, '-fconstexpr-steps=1'),
+          actions=[AddCompileFlag('-fconstexpr-steps=128000000')]),
+
----------------
Are we sure we want to bring this right to the maximum? This could increase the built time by 100x when you actually have bad code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131836/new/

https://reviews.llvm.org/D131836