[libcxx-commits] [PATCH] D121436: [libc++][ranges] Add ranges::out_value_result

Hui via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 15 13:05:25 PDT 2022


huixie90 accepted this revision as: huixie90.
huixie90 added a comment.

LGTM with comments addressed and green CI



================
Comment at: libcxx/test/std/algorithms/algorithms.results/out_value_result.pass.cpp:65
+constexpr bool test() {
+  { // check that the conversion operator works
+    out_value_result<int, double> res{10, 0.};
----------------
I would also add a runtime test to check out the `&&` overload works (for move only types)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121436/new/

https://reviews.llvm.org/D121436



More information about the libcxx-commits mailing list