[libcxx-commits] [PATCH] D131082: [libcxx] Add _LIBCPP_NODEBUG to std::conditional related typedfs

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

In D131082#3721806 <https://reviews.llvm.org/D131082#3721806>, @philnik wrote:

> I don't think we should strip debug information in the public API. Instead, we should try to remove as much implementation-detail debug-info as possible.

Hmm, I can't find the internal or external discussions related to the previous work in this direction, but I was part of them & it was a direction I initially proposed that was implemented here: https://github.com/llvm/llvm-project/commit/14d4869209cc8ff9a53aaa5a59d6409fbc1c5f5d

I'm still generally in favor of that direction (as someone who's spent years working on debug info size issues) - the type traits don't generally add value to a debugger/user of a debugger - being able to look straight through the trait and see the underlying type rather than being presented with the trait as the type is, I believe, generally a better user experience and a better size experience.

Do you have use cases where you find the trait info helpful, as a debug-info user?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131082/new/

https://reviews.llvm.org/D131082