[libcxx-commits] [PATCH] D131371: [libc++] Implement `operator<=>` for `error_{code, condition}`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Aug 14 10:10:08 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM module some nits.



================
Comment at: libcxx/include/system_error:456
+
+inline _LIBCPP_INLINE_VISIBILITY
+strong_ordering
----------------



================
Comment at: libcxx/include/system_error:460
+{
+    if (auto __c = __x.category() <=> __y.category(); __c != 0) return __c;
+    return __x.value() <=> __y.value();
----------------
Please format the new code so `return` is placed properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131371/new/

https://reviews.llvm.org/D131371



More information about the libcxx-commits mailing list