[libcxx-commits] [PATCH] D131854: [libc++][test] fix C4267 warning in bitset.members\to_ulong.pass.cpp

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Aug 14 07:35:57 PDT 2022


philnik added a comment.

I mean why are you casting it to `unsigned long`? AFAICT `std::bitset()` should take an `unsigned long long`, so it shouldn't be a narrowing conversion when calling it with `std::size_t`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131854/new/

https://reviews.llvm.org/D131854



More information about the libcxx-commits mailing list