[libcxx-commits] [PATCH] D131421: [libc++] Uses operator<=> in string.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/string:378
 template<class charT, class traits, class Allocator>
-bool operator==(const charT* lhs, const basic_string<charT, traits, Allocator>& rhs) noexcept;  // constexpr since C++20
+bool operator==(const charT* lhs, const basic_string<charT, traits, Allocator>& rhs) noexcept;  // constexpr since C++20, removed in C++20
 
----------------
Mordante wrote:
> philnik wrote:
> > These shouldn't both be `constexpr` since C++20 and removed in C++20.
> That's how it's implemented at the moment so I prefer to keep the synopsis as is. But we can remove the `_LIBCPP_CONSTEXPR_AFTER_CXX17` for the removed functions, that shouldn't affect the tests.
> 
> I'll make a followup for that.
See D131857.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131421/new/

https://reviews.llvm.org/D131421