[libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates marked 4 inline comments as done.
mumbleskates added a comment.

okay, every comment is either resolved or involves work that should go into another differential.



================
Comment at: libcxx/include/variant:747
   public:                                                                      \
-    inline _LIBCPP_INLINE_VISIBILITY                                           \
+    _LIBCPP_HIDE_FROM_ABI                                           \
     explicit constexpr __union(__valueless_t) noexcept : __dummy{} {}          \
----------------
Mordante wrote:
> please fix the formatting, can you also fix line 742?
i got these a couple updates ago :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131372/new/

https://reviews.llvm.org/D131372