[libcxx-commits] [PATCH] D131082: [libcxx] Add _LIBCPP_NODEBUG to std::conditional related typedfs

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for the patch, LGTM!

> ! @dblaikie wrote:
>  I'm also looking at other instantiations caused by that change that
>  might be able to be addressed - but a quick grep shows ~200 "type"
>  typedefs missing _LIBCPP_NODEBUG, so maybe a systematic application of
>  the typedef might be suitable?

I had a quick look and we indeed don't use this macro often and could use it more.
I've mentioned this patch on the #libcxx Discord channel so we can discuss it there further.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131082/new/

https://reviews.llvm.org/D131082