[libcxx-commits] [PATCH] D131835: [libc++][test] Disables clang-tidy test for GCC.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Aug 13 06:04:00 PDT 2022


Mordante created this revision.
Mordante added a reviewer: philnik.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Increasing the constexpr evaluation limit breaks this clang-tidy test
for GCC. As discussed in D131317 <https://reviews.llvm.org/D131317> disable the test in GCC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131835

Files:
  libcxx/test/libcxx/clang_tidy.sh.cpp


Index: libcxx/test/libcxx/clang_tidy.sh.cpp
===================================================================
--- libcxx/test/libcxx/clang_tidy.sh.cpp
+++ libcxx/test/libcxx/clang_tidy.sh.cpp
@@ -8,10 +8,11 @@
 
 // REQUIRES: has-clang-tidy
 
+// The GCC compiler flags are not always compatible with clang-tidy.
+// UNSUPPORTED: gcc
+
 // TODO: run clang-tidy with modules enabled once they are supported
-// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --config-file=%S/../../.clang-tidy -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags} -fno-modules
-// -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
-// There are some GCC-specific ones where clang-tidy would warn otherwise.
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --config-file=%S/../../.clang-tidy -- -Wweak-vtables %{compile_flags} -fno-modules
 
 // Prevent <ext/hash_map> from generating deprecated warnings for this test.
 #if defined(__DEPRECATED)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131835.452418.patch
Type: text/x-patch
Size: 1022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220813/125bb687/attachment.bin>


More information about the libcxx-commits mailing list