[libcxx-commits] [PATCH] D130860: [libc++] Implement `operator<=>` for `filesystem::directory_entry`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

SGTM modulo some minor issues.



================
Comment at: libcxx/include/__filesystem/directory_entry.h:254
+
+  _LIBCPP_INLINE_VISIBILITY
+  strong_ordering operator<=>(const directory_entry& __rhs) const noexcept {
----------------
Please use `_LIBCPP_HIDE_FROM_ABI` in new code and only use one blank line.


================
Comment at: libcxx/include/__filesystem/directory_entry.h:255
+  _LIBCPP_INLINE_VISIBILITY
+  strong_ordering operator<=>(const directory_entry& __rhs) const noexcept {
+    return __p_ <=> __rhs.__p_;
----------------
Please update the synopsis.


================
Comment at: libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/comparisons.pass.cpp:32
+  static_assert(std::is_same<decltype(ce Op ce), Ret>::value, "");                                                     \
+  static_assert(noexcept(ce Op ce), "Operation must be noexcept")
 
----------------
Instead of updating this macro can you use the generic test macros?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130860/new/

https://reviews.llvm.org/D130860