[libcxx-commits] [PATCH] D131681: [libc++] Add a missing assertion in std::span's constructor

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 11 14:18:29 PDT 2022


jloser added a comment.

LGTM! I checked the other methods like `first`, `last`, `subspan`, etc. and I'm happy with the coverage for testing `LIBCPP_ASSERT`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131681/new/

https://reviews.llvm.org/D131681



More information about the libcxx-commits mailing list