[libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>

Adrian Vogelsgesang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 11 14:05:44 PDT 2022

Previous message: [libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>
Next message: [libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

avogelsgesang accepted this revision.
avogelsgesang added a comment.

LGTM, after addressing @philnik's comment regarding the `TEST_NODISCARD` macro.
Thank you! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131372/new/

https://reviews.llvm.org/D131372

Previous message: [libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>
Next message: [libcxx-commits] [PATCH] D131372: [libc++][spaceship] Implement std::variant::operator<=>
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the libcxx-commits mailing list