[libcxx-commits] [PATCH] D130854: [libc++][NFC] Qualify declval

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM, but the only problem I have with the patch is that there's currently no way of enforcing it. Can we investigate adding a test for this (maybe with `clang-query`)? Otherwise, we can just `grep` our headers with something like `grep -E 'declval<' -R libcxx/include | grep -v -E 'std::declval<'`. Otherwise, I think it's definitely possible to come up with a single regex to do it, using negative lookahead, but I'm not sure all regex engines support it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130854/new/

https://reviews.llvm.org/D130854